[Home]WikiBugs/CompareButtonFailsToDiff

UseModWiki | WikiBugs | RecentChanges | Preferences

This is a bug in the new diff code for 1.0. The wiki that inspired this new diff code (selecting revisions with a compare button) did not allow single quotes so it was not noticed there. See the Bugfix Instructions below for an immediate fix, and WikiBugs for plans to fix the release. --CliffordAdams

Fixed in 1.0.1 --MarkusLude


I've installed the 1.0 download on windows and have the GNU utilities for Win32 installed to provide a version of diff.

Reviewing page revisions and using the Compare button works fine for most pages

For pages which include a single quote e.g. Brian's_Home_Page the Compare gives the message

Revision 48 not available (showing current revision instead)
and the page URl is something like action=browse&diff=1&id=Brian&revision=48&diffrevision=47
i.e. The page name is truncated at the quote

I previously used version 0.92 and the diff link coped with this.

  --BrianHunter

Bugfix Instructions

In the sub DoHistory { subroutine change the line
       <input type='hidden' name='id' value='$id'/>  
to
       <input type='hidden' name='id' value="$id"/>  

I've have not confirmed that there is no other knock on from this change but it looks good so far --BrianHunter

There should be no problems with this change (changing the single quotes to double quotes), as double-quotes are never allowed in page names. --CliffordAdams

UseModWiki | WikiBugs | RecentChanges | Preferences
Edit text of this page | View other revisions | Search MetaWiki
Last edited October 12, 2007 8:06 pm by JuanmaMP (diff)
Search: