[Home]WikiBugs/BadHtml

UseModWiki | WikiBugs | RecentChanges | Preferences

Fixed in 1.0.1 --MarkusLude

HTML code for error messages isn't correct:

 <H2>Invalid action parameter foo</H2></body></html>

Fixes:

in function ReportError change

 print $q->header, "<H2>", &QuoteHtml?($errmsg), "</H2>", $q->end_html;
to
 print $q->header, $q->start_html, "<H2>", &QuoteHtml?($errmsg), "</H2>", $q->end_html;

at the end of function DoEdit change ordering

 print $q->endform;
 print '</div>';
to
 print '</div>';
 print $q->endform;

towards the end of function DoEditPrefs? change

 print '</div>';
 print "<hr class=wikilinefooter>\n";
 print '<div class=wikifooter>';
 print &GetGotoBar('');
 print $q->endform;
to
 print $q->endform;
 print '</div>';
 print "<hr class=wikilinefooter>\n";
 print '<div class=wikifooter>';
 print &GetGotoBar('');

sorry, I currently have no clean 1.0 script to provide a clean diff.

see also WikiBugs/AmpersandBug for another problem with the HTML code.

--MarkusLude


UseModWiki | WikiBugs | RecentChanges | Preferences
Edit text of this page | View other revisions | Search MetaWiki
Last edited October 25, 2007 8:52 am by MarkusLude (diff)
Search: